Improve tests #393
Merged
Improve tests #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forsyth2
added
Testing
forsyth2
commented
Oct 18, 2025
Collaborator
Author
There was a problem hiding this comment.
This PR is almost exclusively test changes. Since we are in the E3SM Unified testing period, and iteratively updating tests accordingly, I'm just going to go ahead and merge this.
The only non-testing attribute changed is that the permissible versions of globus-sdk needed an upper bound to pass tests. As such, I will make a zstash rc3 after merging this PR.
| - sqlite | ||
| - six >=1.16.0 | ||
| - globus-sdk >=3.15.0 | ||
| - globus-sdk >=3.15.0,<4.0 |
Collaborator
Author
There was a problem hiding this comment.
Without this, we get AttributeError: 'TransferClient' object has no attribute 'endpoint_autoactivate'
| # for new auth credentials in case they have expired: | ||
| if [[ $# -gt 1 ]]; then | ||
| if [[ $2 == "NEW_CREDS" ]]: then | ||
| rm -f ~/.globus-native-apps.cfg |
Collaborator
Author
There was a problem hiding this comment.
This file is no longer used, as of #380.
This was referenced Oct 18, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR better structures existing tests, so it is clearer how to run each of them. It is not significantly changing what we're testing.
Objectives:
try_#paths)pytest(The tests intests/integration/python_testswill require more effort to convert over).condasetup accordingly to get tests working.Issue resolution:
Select one: This pull request is...
Small Change